BUG: Ensure compile errors are raised correctly#21442
Merged
charris merged 1 commit intonumpy:mainfrom May 5, 2022
Merged
Conversation
This has been bugging me for a bit. The concurrent.futures Executor requires checking the result for the error to be raised. That makes sense, but just means we need to consume the result explicitly here to ensure we know about compile errors. Otherwise, compile errors just pass silently (which is very confusing if the old object files are still around and the tests run based on the old version).
Member
|
Thanks Sebastian. Do you still want this backported? |
Member
Author
|
Yeah, I noticed the fix (as in the PR that caused this) was backported, so I think it probably makes sense. I added it because I think it might also affect downstream, in principle, for the branch development itself it really wouldn't matter... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been bugging me for a bit. The concurrent.futures Executor
requires checking the result for the error to be raised. That makes
sense, but just means we need to consume the result explicitly here
to ensure we know about compile errors.
Otherwise, compile errors just pass silently (which is very confusing
if the old object files are still around and the tests run based on
the old version).