Skip to content

MAINT: Update doc requirements#21417

Merged
mattip merged 1 commit intonumpy:mainfrom
jarrodmillman:update-doc-requirements
May 1, 2022
Merged

MAINT: Update doc requirements#21417
mattip merged 1 commit intonumpy:mainfrom
jarrodmillman:update-doc-requirements

Conversation

@jarrodmillman
Copy link
Copy Markdown
Member

No description provided.

@seberg
Copy link
Copy Markdown
Member

seberg commented Apr 30, 2022

Thanks Jarrod, there is another copy of these in environment.yaml, IIRC that should change too.

@jarrodmillman jarrodmillman force-pushed the update-doc-requirements branch from dbecd8e to 9557ff7 Compare May 1, 2022 00:22
@mattip
Copy link
Copy Markdown
Member

mattip commented May 1, 2022

I am a little worried about upgrading the theme from 0.7.2 to 0.8.1. Reading through the changelog it seems there are some slight style changes. Did you look at these when upgrading the version?

@seberg
Copy link
Copy Markdown
Member

seberg commented May 1, 2022

Looking through the style changes, none of them strike me as changes we should worry about. I would be +1 with just going ahead and upstreaming any issues if they crop up.

(I am wondering if we should backport this for the sake of also backporting the version picker eventually?)

@mattip mattip merged commit 9ee47e0 into numpy:main May 1, 2022
@mattip
Copy link
Copy Markdown
Member

mattip commented May 1, 2022

Thanks @jarrodmillman. As for backporting, we usually do not rebuild older versions of the documentation, right?

@charris
Copy link
Copy Markdown
Member

charris commented May 1, 2022

we usually do not rebuild older versions of the documentation, right?

There was a request that we rebuild the 1.22 documentation to fix linking problems.

@mattip
Copy link
Copy Markdown
Member

mattip commented May 6, 2022

There was a request that we rebuild the 1.22 documentation to fix linking problems.

So this should be backported to 1.22 and then we should rebuild the docs. I guess that would be an opportunity to also get the version pulldown.

@charris charris added the 09 - Backport-Candidate PRs tagged should be backported label May 6, 2022
@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label May 10, 2022
@charris
Copy link
Copy Markdown
Member

charris commented May 10, 2022

@mattip Is the version picker ready? I'm planning to release 1.22.4 this week.

@mattip
Copy link
Copy Markdown
Member

mattip commented May 10, 2022

The version picker is available in the devdocs and so far seems to work as advertised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants