Skip to content

BUG: add linux guard per #21386#21392

Merged
charris merged 1 commit intonumpy:mainfrom
jmgurney:main
Apr 26, 2022
Merged

BUG: add linux guard per #21386#21392
charris merged 1 commit intonumpy:mainfrom
jmgurney:main

Conversation

@jmgurney
Copy link
Copy Markdown
Contributor

@jmgurney jmgurney commented Apr 25, 2022 •
edited by charris
Loading

Closes #21386.

@jmgurney
Copy link
Copy Markdown
Contributor Author

jmgurney commented Apr 25, 2022

This compiles fine on FreeBSD:

$ pip install -e git+https://github.com/jmgurney/numpy.git'#egg=numpy'
Obtaining numpy from git+https://github.com/jmgurney/numpy.git#egg=numpy
  Cloning https://github.com/jmgurney/numpy.git to ./p/src/numpy
  Running command git clone --filter=blob:none --quiet https://github.com/jmgurney/numpy.git /home/freebsd/haws/p/src/numpy
load: 0.33  cmd: git 72349 [running] 14.71r 0.93u 1.14s 21% 28764k
  Resolved https://github.com/jmgurney/numpy.git to commit a8663f6c368d4b20e20ea7b6612aced63d334a4f
  Running command git submodule update --init --recursive -q
  Installing build dependencies ... done
  Checking if build backend supports build_editable ... done
  Getting requirements to build wheel ... done
  Preparing metadata (pyproject.toml) ... done
Installing collected packages: numpy
  Attempting uninstall: numpy
    Found existing installation: numpy 1.21.0.dev0+436.g5c7002926
    Uninstalling numpy-1.21.0.dev0+436.g5c7002926:
      Successfully uninstalled numpy-1.21.0.dev0+436.g5c7002926
  Running setup.py develop for numpy
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
[...]
Successfully installed numpy-1.23.0.dev0+1084.ga8663f6c3

Note that the hashes differ, only because I was told too late that commit messages have to have a specific format to them, and had to amend the commit.

@charris charris added the 09 - Backport-Candidate PRs tagged should be backported label Apr 25, 2022
@charris charris added this to the 1.22.4 release milestone Apr 25, 2022
@charris charris merged commit fd646bd into numpy:main Apr 26, 2022
@charris
Copy link
Copy Markdown
Member

charris commented Apr 26, 2022

Thanks @jmgurney .

@InessaPawson
Copy link
Copy Markdown
Member

InessaPawson commented Apr 26, 2022

Hi-five on merging your first pull request to NumPy, @jmgurney! We hope you stick around! Your choices aren’t limited to programming – you can review pull requests, help us stay on top of new and old issues, develop educational material, work on our website, add or improve graphic design, create marketing materials, translate website content, write grant proposals, and help with other fundraising initiatives. For more info, check out: https://numpy.org/contribute
Also, consider joining our mailing list. This is a great way to connect with other cool people in our community and be part of important conversations that affect the development of NumPy: https://mail.python.org/mailman/listinfo/numpy-discussion

@charris charris mentioned this pull request May 5, 2022
Merged
@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label May 5, 2022
@charris charris removed this from the 1.22.4 release milestone May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

00 - Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BUG: getauxval declaration invalid, causes compile issues

3 participants

@jmgurney @charris @InessaPawson