BUG: Make mmap handling safer in frombuffer#21324
Merged
charris merged 1 commit intonumpy:mainfrom Apr 21, 2022
Merged
Conversation
seberg
commented
Apr 11, 2022
| def test_empty(self): | ||
| assert_array_equal(np.frombuffer(b''), np.array([])) | ||
|
|
||
| def test_mmap_close(self): |
Member
Author
There was a problem hiding this comment.
@mattip the test just needs to be skipped on PyPy, or is there something else going on?
Member
There was a problem hiding this comment.
PyPy does not track the number of exported mmap references, and so the same segfault that occurs in issue gh-9537 will still happen in PyPy. I opened an issue on PyPy but it is complicated to properly support this. https://foss.heptapod.net/pypy/pypy/-/issues/3724
Member
Author
There was a problem hiding this comment.
Thanks, makes sense since it adds another level of reference counting effectively.
`frombuffer` always used the old buffer protocol, but this is not safe in some cases when combined with the "new" one. The main/only use-case that was ever found for this is that enabling the new buffer protocol (by going through a memoryview) protects users from accidentally closing memorymaps while they are still used. Closes numpygh-9537
Member
|
Thanks Sebastian. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
frombufferalways used the old buffer protocol, but this is notsafe in some cases when combined with the "new" one.
The main/only use-case that was ever found for this is that enabling
the new buffer protocol (by going through a memoryview) protects
users from accidentally closing memorymaps while they are still used.
Closes gh-9537