MAINT: Split numpy.typing into a public and private component#21216
Merged
charris merged 4 commits intonumpy:mainfrom Mar 25, 2022
Merged
MAINT: Split numpy.typing into a public and private component#21216charris merged 4 commits intonumpy:mainfrom
numpy.typing into a public and private component#21216charris merged 4 commits intonumpy:mainfrom
Conversation
Member
Author
|
The linting errors pertain a number of docstrings and |
Member
|
I ignore linting for the typing files :) We can always look at cleaning them up later if it seems appropriate. I haven't really looked at the code here, just scanned to see what you did. I figure if there are problems they will be discovered down stream and you will fix them. So in it goes. Thanks Bas. |
Member
Author
|
I wouldn't anticipate any issues unless people are using private API; most of the changes introduced herein can basically be boiled down to renaming |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #21214
This PR does accomplishes two things:
numpy.typinginto a public and private sub-package, allowing a greater degree of separation of the public interface from the list of private types and type-aliases. This one in particular has been on my wish list for some time due to the ever growing number of private members.numpy.typingsub-package were already explicitly marked as re-exported, this was not the case for its' private members, resulting in BUG: Usage of implicit reexports breaks using mypy with--no-implicit-reexport#21214. This issues has been rectified in 70176f6, which should be backported to 1.22.4 (I'll create a PR once this one is merged, as I anticipate a merge conflict or two).