BUG: Fix missing intrinsics for windows/arm64 target #20931
Merged
charris merged 2 commits intonumpy:mainfrom Jan 28, 2022
Merged
BUG: Fix missing intrinsics for windows/arm64 target #20931charris merged 2 commits intonumpy:mainfrom
charris merged 2 commits intonumpy:mainfrom
Conversation
Do not use __popcnt and variants for windows/arm64 target
ganesh-k13
reviewed
Jan 28, 2022
| #if (defined(__clang__) || defined(__GNUC__)) && NPY_BITSOF_@STYPE@ >= 32 | ||
| return __builtin_popcount@c@(a); | ||
| #elif defined(_MSC_VER) && NPY_BITSOF_@STYPE@ >= 16 | ||
| #elif defined(_MSC_VER) && NPY_BITSOF_@STYPE@ >= 16 && !defined(_M_ARM64) |
Member
There was a problem hiding this comment.
Thanks for the fix! I'm not aware of ARM(hence I missed it), but should we add _M_ARM as well?
ganesh-k13
approved these changes
Jan 28, 2022
Member
|
Thanks @nsait-linaro . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20930
__popcnt and variants are not available for arm64 msvc intrinsic so use numpy population count implementation for win/arm64 targets.
https://docs.microsoft.com/en-us/cpp/intrinsics/arm64-intrinsics?view=msvc-170
Test Result
16356 passed, 649 skipped, 1296 deselected, 18 xfailed, 1 xpassed in 245.28s (0:04:05)