MAINT: remove outdated mingw32 fseek support#20847
Merged
charris merged 1 commit intonumpy:mainfrom Jan 18, 2022
Merged
Conversation
`_fseeki64` and `_ftelli64` have been present in mingw-w64 for a long time, see mingw-w64/mingw-w64@d66350e This fixes an annoying build warning in the SciPy Meson build: ``` C:\hostedtoolcache\windows\Python\3.9.9\x64\lib\site-packages\numpy\core\include/numpy/npy_common.h:185:20: warning: 'int _fseeki64(FILE*, long long int, int)' redeclared without dllimport attribute after being referenced with dll linkage 185 | extern int __cdecl _fseeki64(FILE *, long long, int); | ^~~~~~~~~ C:\hostedtoolcache\windows\Python\3.9.9\x64\lib\site-packages\numpy\core\include/numpy/npy_common.h:186:26: warning: 'long long int _ftelli64(FILE*)' redeclared without dllimport attribute after being referenced with dll linkage 186 | extern long long __cdecl _ftelli64(FILE *); | ^~~~~~~~~ ``` It's only happening for Pythran extensions, because Pythran uses `fseek`. The cause is otherwise unrelated to Pythran though, it's `npy_common.h` redefining something that's in mingw-w64.
Contributor
|
Seems reasonable - the mingw-w64 commit is from November 2018 - so a good long time ago. |
Member
Author
That's just moving things around, it's been in the code base since before 2010. It's the most useful commit message, that's why I linked to it. |
Member
|
Thanks Ralf. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_fseeki64and_ftelli64have been present in mingw-w64 for a long time, see mingw-w64/mingw-w64@d66350eThis fixes an annoying build warning in the SciPy Meson build:
It's only happening for Pythran extensions, because Pythran uses
fseek. The cause is otherwise unrelated to Pythran though, it'snpy_common.hredefining something that's in mingw-w64.Cc @carlkl, @matthew-brett