Skip to content

Conversation

@radarhere
Copy link
Contributor

Removed the deprecated functionality from gh-19001

@mattip
Copy link
Member

mattip commented Jan 17, 2022

I think we usually wait at least two years before removing deprecated behaviour. Is there a reason to rush the schedule for this?

@seberg
Copy link
Member

seberg commented Jan 17, 2022

I think it s currently at least one year/two releases (on a 6month schedule)? So we could probably do it now, as it would hit only by 1.23 and was introduced in 1.21. And I doubt there are important reasons for taking this one slow.

@seberg
Copy link
Member

seberg commented Jan 31, 2022

Thanks @radarhere, lets give this a shot, if anyone disagrees please comment and we can revert.

@seberg seberg merged commit 862994c into numpy:main Jan 31, 2022
@radarhere radarhere deleted the finish_deprecation branch January 31, 2022 21:25
@InessaPawson
Copy link
Member

Hi-five on merging your first pull request to NumPy, @radarhere! We hope you stick around! Your choices aren’t limited to programming – you can review pull requests, help us stay on top of new and old issues, develop educational material, work on our website, add or improve graphic design, create marketing materials, translate website content, write grant proposals, and help with other fundraising initiatives. For more info, check out: https://numpy.org/contribute
Also, consider joining our mailing list. This is a great way to connect with other cool people in our community and be part of important conversations that affect the development of NumPy: https://mail.python.org/mailman/listinfo/numpy-discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants