BUG: Fix comparator function signatures#20833
Merged
seberg merged 1 commit intonumpy:mainfrom Jan 16, 2022
Merged
Conversation
The comparator functions are expected to have signature int f(void *, void*, PyArrayObject *). Some of the comparators drop the third argument because they don't use them. Because the comparators are unused, with most architectures this works fine. However, calling a function pointer that has been cast to have a different number of arguments is undefined in the C specification. With web assembly targets, it crashes at runtime. This fixes the comparators defined in arraytypes.c.src to all take three arguments. See also related work: 258ce25 23c05e6
Member
|
LGTM, thanks for this cleanup @hoodmane. (Oddly, the typedef uses |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comparator functions are expected to have signature
int f(void *, void*, PyArrayObject *).Some of the comparators drop the third argument because they don't use them. Because the
comparators are unused, with most architectures this works fine. However, calling a function
pointer that has been cast to have a different number of arguments is undefined in the C
specification. With web assembly targets, it crashes at runtime.
This fixes the comparators defined in
arraytypes.c.srcto all take three arguments.See also related work:
258ce25
23c05e6