BUG: Return correctly shaped inverse indices in array_api set functions#20791
Merged
charris merged 2 commits intonumpy:mainfrom Jan 13, 2022
Merged
BUG: Return correctly shaped inverse indices in array_api set functions#20791charris merged 2 commits intonumpy:mainfrom
array_api set functions#20791charris merged 2 commits intonumpy:mainfrom
Conversation
Member
|
If there is a test for this, could you add it here? |
Specifically for `xp.unique_all()` and `xp.unique_inverse()`
5420bb2 to
ccc1091
Compare
Contributor
Author
Done! Like with #20788, I've added a test which just hones in on the diverging behaviour from NumPy proper here i.e. inverse indices sharing the input array shape. Hope that's okay—the tests in
|
Member
|
Thanks @honno . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As inverse indices from
np.unique()are flattened whenaxis=None(the default), the relatedarray_apiset functions (xp.unique_inverse/xp.unique_all) don't return shape-sharing indices as the Array API specifies. This PR fixes this by internally reshaping the inverse indices.Tested in array-api-tests , specifically https://github.com/data-apis/array-api-tests/blob/master/array_api_tests/test_set_functions.py. Note these tests will fail due to unrelated NaN-uniqueness issues.
Related #20638