TYP: change type annotation for __array_namespace__ to ModuleType#20719
Merged
BvB93 merged 1 commit intonumpy:mainfrom Jan 3, 2022
Merged
TYP: change type annotation for __array_namespace__ to ModuleType#20719BvB93 merged 1 commit intonumpy:mainfrom
__array_namespace__ to ModuleType#20719BvB93 merged 1 commit intonumpy:mainfrom
Conversation
This is more precise, we are returning a module here. Type checkers will be able to use this info in the future - see data-apis/array-api#267
BvB93
approved these changes
Jan 3, 2022
Member
BvB93
left a comment
There was a problem hiding this comment.
LGTM, it seems the necasary ModuleType.__getattr__ changes are available as of mypy 0.930.
Member
|
Thanks @rgommers. |
Member
|
Not sure if this needs a backport though, considering the changes in this PR don't deal with any false positives (though feel free to leave the backport-candidate label if you want it backported). |
Member
|
@bas I am mostly prompted by "in the future". General adoption of a numpy version can take a year or more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is more precise, we are returning a module here. Type checkers will be able to use this info in the future - see data-apis/array-api#267