Skip to content

MAINT: update wheel to version that supports python3.10#20486

Merged
charris merged 2 commits intonumpy:mainfrom
mattip:update-wheel
Nov 30, 2021
Merged

MAINT: update wheel to version that supports python3.10#20486
charris merged 2 commits intonumpy:mainfrom
mattip:update-wheel

Conversation

@mattip
Copy link
Member

@mattip mattip commented Nov 29, 2021

xref pypa/wheel#426 and pypa/pip#10631.

The release blurb for this version states

Added official Python 3.10 support

I think updating the vendored "packaging" package also fixes the linked pypy3.8 issues

@mattip mattip added the 09 - Backport-Candidate PRs tagged should be backported label Nov 29, 2021
@charris
Copy link
Member

charris commented Nov 29, 2021

Should probably pin the version in test_requirements as well, wheel<0.37.1 allows earlier versions.

@mattip
Copy link
Member Author

mattip commented Nov 29, 2021

I wonder why wheel appears in the test_requirements.txt in the first place. Is there a test that builds wheels? Maybe because we use run_tests.py which calls setup.py install and not pip install (which would check the pyproject.toml)?

Anyhow I pinned wheel in the test_requirements.txt and also removed a python3.7 remnant.

@charris charris merged commit 4906ce8 into numpy:main Nov 30, 2021
@charris
Copy link
Member

charris commented Nov 30, 2021

Thanks Matti.

@gwerbin
Copy link

gwerbin commented Nov 30, 2021

Thanks so much everyone for looking into this!

Does this fix the PyPy 3.7 wheel issue as well? That's what originally triggered the bug report.

@charris
Copy link
Member

charris commented Nov 30, 2021

Does this fix the PyPy 3.7 wheel issue as well?

It would need to be backported to 1.21.x to make a difference as we have dropped 3.7. I will do one more 1.21 release, it would be good if someone could check if this works.

@charris charris added this to the 1.21.5 release milestone Nov 30, 2021
@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Nov 30, 2021
@charris charris removed this from the 1.21.5 release milestone Nov 30, 2021
@mattip mattip deleted the update-wheel branch December 27, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants