Skip to content

MAINT: Fix longdouble precision check in test_umath.py#20427

Merged
charris merged 1 commit intonumpy:mainfrom
charris:fix-umath-longdouble-test
Nov 21, 2021
Merged

MAINT: Fix longdouble precision check in test_umath.py#20427
charris merged 1 commit intonumpy:mainfrom
charris:fix-umath-longdouble-test

Conversation

@charris
Copy link
Member

@charris charris commented Nov 21, 2021

This is a partial reversion of #20274. My guess is that
glibc_older_than("2.19") is not working correctly using manylinux2014
on aarch64.

Closes #20426.

This is a partial reversion of numpy#20274. My guess is that
`glibc_older_than("2.19")` is not working correctly on manylinux2014
on aarch64.

Closes numpy#20426.
@charris charris added this to the 1.22.0 release milestone Nov 21, 2021
@charris
Copy link
Member Author

charris commented Nov 21, 2021

This problem was only seen in the wheel builds, so this needs to be merged to check if the fix is good.

@charris charris merged commit dc2b556 into numpy:main Nov 21, 2021
@charris charris deleted the fix-umath-longdouble-test branch November 21, 2021 17:56
@charris
Copy link
Member Author

charris commented Nov 21, 2021

Travis is stuck.

@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Nov 21, 2021
@charris charris removed this from the 1.22.0 release milestone Nov 21, 2021
@h-vetinari
Copy link
Contributor

Sorry for the breakage, just saw this now. It's seems possible or even plausible to me that that the get_glibc_version might be broken entirely on ppc, especially if it uses a different name for the env-var than CS_GNU_LIBC_VERSION.

@charris
Copy link
Member Author

charris commented Apr 11, 2022

Sorry for the breakage

Given that was a problem with manylinux2014, the problem may be with the docker images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test failures on nightly ARM64 wheel builds.

2 participants