Skip to content

BLD: Try making 64-bit Windows wheels#20383

Merged
mattip merged 1 commit intonumpy:mainfrom
lithomas1:patch-1
Nov 19, 2021
Merged

BLD: Try making 64-bit Windows wheels#20383
mattip merged 1 commit intonumpy:mainfrom
lithomas1:patch-1

Conversation

@lithomas1
Copy link
Copy Markdown
Contributor

@lithomas1 lithomas1 commented Nov 16, 2021 •
edited
Loading

No description provided.

@github-actions github-actions bot added the 36 - Build Build related PR label Nov 16, 2021
lithomas1
lithomas1 commented Nov 16, 2021
View reviewed changes
@lithomas1
Copy link
Copy Markdown
Contributor Author

lithomas1 commented Nov 16, 2021

Not sure if openblas linked correctly.
I see
libraries openblas64_ not found in ['openblas', 'C:\\cibw\\python\\python.3.8.10\\tools\\lib', 'C:\\', 'C:\\cibw\\python\\python.3.8.10\\tools\\libs']
but also openblas64__info: library_dirs = ['C:\\Users\\runneradmin\\AppData\\Local\\Temp\\pip-req-build-r9rwumpo\\build\\openblas64__info'] libraries = ['openblas64__info'] language = f77 define_macros = [('HAVE_CBLAS', None), ('BLAS_SYMBOL_SUFFIX', '64_'), ('HAVE_BLAS_ILP64', None)] blas_ilp64_opt_info: library_dirs = ['C:\\Users\\runneradmin\\AppData\\Local\\Temp\\pip-req-build-r9rwumpo\\build\\openblas64__info'] libraries = ['openblas64__info'] language = f77 define_macros = [('HAVE_CBLAS', None), ('BLAS_SYMBOL_SUFFIX', '64_'), ('HAVE_BLAS_ILP64', None)]
I think the Azure build also has the openblas not found message, so it might be fine.

@mattip
Copy link
Copy Markdown
Member

mattip commented Nov 16, 2021

There is one failing test, which is preventing the artifact from being uploaded. Could you xfail/skip that test for now so we can check that the artifact does indeed have openblas?

@mattip
Copy link
Copy Markdown
Member

mattip commented Nov 16, 2021

It is a pretty involved test anyway, mainly for testing that fortran compiling works.

@lithomas1
Copy link
Copy Markdown
Contributor Author

lithomas1 commented Nov 16, 2021

There is one failing test, which is preventing the artifact from being uploaded. Could you xfail/skip that test for now so we can check that the artifact does indeed have openblas?

Done.

@mattip
Copy link
Copy Markdown
Member

mattip commented Nov 16, 2021 •
edited
Loading

Cool. It works:

>>> import ctypes
>>> dll = ctypes.CDLL(r"C:\temp\vtest_python38\Lib\site-packages\numpy\.libs\libopenblas.EL2C6PLE4ZYW3ECEVIV3OXXGRN2NRFM2.gfortran-win_amd64.dll")
>>> get_config = dll.openblas_get_config64_
>>> get_config.restype = ctypes.c_char_p
>>> get_config()
b'OpenBLAS 0.3.18  USE64BITINT DYNAMIC_ARCH NO_AFFINITY Haswell MAX_THREADS=24'

@lithomas1 lithomas1 marked this pull request as ready for review November 16, 2021 23:43
@lithomas1
Copy link
Copy Markdown
Contributor Author

lithomas1 commented Nov 17, 2021

This should be working now. Let me know if you want this squashed.

lithomas1
lithomas1 commented Nov 17, 2021
View reviewed changes
@mattip mattip mentioned this pull request Nov 17, 2021
Closed
@mattip
Copy link
Copy Markdown
Member

mattip commented Nov 17, 2021

LGTM. Would you like to try to add 32-bit windows or is this enough for one PR?

@mattip
Copy link
Copy Markdown
Member

mattip commented Nov 17, 2021

Could you also add a --std=c99 exclusion as per this comment to unbreak the macos builds

@lithomas1 lithomas1 changed the title BLD: Try making Windows wheels BLD: Try making 64-bit Windows wheels Nov 18, 2021
@lithomas1 lithomas1 force-pushed the patch-1 branch 3 times, most recently from bf8d234 to d8e6992 Compare November 18, 2021 00:42
@lithomas1
Copy link
Copy Markdown
Contributor Author

lithomas1 commented Nov 18, 2021

Changes to build on macOS are merged in main. I'll squash to trigger wheel builds again tomorrow.

@mattip
Copy link
Copy Markdown
Member

mattip commented Nov 18, 2021

The action title is Build wheel for cp${{ matrix.python }}-${{ matrix.platform } in the CI report block

@mattip mattip mentioned this pull request Nov 18, 2021
Merged
@lithomas1
Add 64 bit Windows builds [wheel build]
2a1284b 
commit 9c833bed5879d77e625556260690c349de18b433
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Wed Nov 17 16:21:27 2021 -0800

    Add Windows config to GHA

    update script [wheel build]

    typo [wheel build]

    fix typo? [wheel build]

    fix linux builds? [wheel build]

    typo [wheel build]

    add license and pin to windows 2016

    skip tests [wheel build]

    pin to windows 2019 instead [wheel build]

    try to find out the error on windows [wheel build]

    maybe fix? [wheel build]

    maybe fix? [wheel build]

    fix? [wheel build]

    cleanup [wheel build]

    Add Windows config to GHA

    update script [wheel build]

    typo [wheel build]

    fix typo? [wheel build]

    fix linux builds? [wheel build]

    typo [wheel build]

    add license and pin to windows 2016

    skip tests [wheel build]

    pin to windows 2019 instead [wheel build]

    try to find out the error on windows [wheel build]

    maybe fix? [wheel build]

    maybe fix? [wheel build]

    fix? [wheel build]

    cleanup [wheel build]

    Update LICENSE_win32.txt

    Update LICENSE_win32.txt

    Add Windows config to GHA

    update script [wheel build]

    typo [wheel build]

    fix typo? [wheel build]

    fix linux builds? [wheel build]

    typo [wheel build]

    add license and pin to windows 2016

    skip tests [wheel build]

    pin to windows 2019 instead [wheel build]

    try to find out the error on windows [wheel build]

    maybe fix? [wheel build]

    maybe fix? [wheel build]

    fix? [wheel build]

    cleanup [wheel build]

    Update LICENSE_win32.txt

    Update LICENSE_win32.txt

    Update cibw_test_command.sh

commit 4bd12df
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Mon Nov 15 17:28:47 2021 -0800

    # This is a combination of 14 commits.
    # This is the 1st commit message:

    Add Windows config to GHA
    # This is the commit message numpy#2:

    update script [wheel build]
    # This is the commit message numpy#3:

    typo [wheel build]
    # This is the commit message numpy#4:

    fix typo? [wheel build]
    # This is the commit message numpy#5:

    fix linux builds? [wheel build]
    # This is the commit message numpy#6:

    typo [wheel build]
    # This is the commit message numpy#7:

    add license and pin to windows 2016
    # This is the commit message numpy#8:

    skip tests [wheel build]
    # This is the commit message numpy#9:

    pin to windows 2019 instead [wheel build]
    # This is the commit message numpy#10:

    try to find out the error on windows [wheel build]
    # This is the commit message numpy#11:

    maybe fix? [wheel build]
    # This is the commit message numpy#12:

    maybe fix? [wheel build]
    # This is the commit message numpy#13:

    fix? [wheel build]
    # This is the commit message numpy#14:

    cleanup [wheel build]
@lithomas1 lithomas1 requested a review from mattip November 18, 2021 23:28
@lithomas1
Copy link
Copy Markdown
Contributor Author

lithomas1 commented Nov 18, 2021

The action title is Build wheel for cp${{ matrix.python }}-${{ matrix.platform } in the CI report block

Oh, the build was getting skipped since the last commit didn't have [wheel build] in it. I've rebased and squashed again.

@mattip mattip merged commit 3774a62 into numpy:main Nov 19, 2021
@mattip
Copy link
Copy Markdown
Member

mattip commented Nov 19, 2021

Thanks @lithomas1

@mattip mattip mentioned this pull request Nov 19, 2021
Closed
3 tasks
@mattip
Copy link
Copy Markdown
Member

mattip commented Nov 19, 2021

Now only windows-32, and pypy3.8 (windows-64, osx-x86_64, manylinux2014, aarch64) are missing, but they are lower priority

@lithomas1 lithomas1 deleted the patch-1 branch November 19, 2021 14:36
@joerick joerick mentioned this pull request Jan 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattip mattip Awaiting requested review from mattip

Assignees

No one assigned

Labels

36 - Build Build related PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lithomas1 @mattip