BUG: Fix headers for universal2 builds#20270
Merged
charris merged 1 commit intonumpy:mainfrom Nov 1, 2021
Merged
Conversation
charris
reviewed
Nov 1, 2021
Member
|
Thanks @isuruf . |
mattip
reviewed
Aug 23, 2022
| #define NPY_SIZEOF_COMPLEX_LONGDOUBLE 32 | ||
| #elif defined(__arm64__) | ||
| #define NPY_SIZEOF_LONGDOUBLE 8 | ||
| #define NPY_SIZEOF_COMPLEX_LONGDOUBLE 16 |
Member
There was a problem hiding this comment.
I am trying to build with the macos-provided clang and getting weird errors because of this. @isuruf Shouldn't this be 16/32?
Contributor
Author
There was a problem hiding this comment.
@isuruf Shouldn't this be 16/32?
No, long double is equivalent to double on macos-arm64
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were some support for universal (intel+powerpc) wheels.
This does something similar for universal2 (intel+arm) wheels