DOC: Ensure that we add documentation also as to the dict for types#20082
Merged
charris merged 2 commits intonumpy:maintenance/1.21.xfrom Oct 10, 2021
Merged
DOC: Ensure that we add documentation also as to the dict for types#20082charris merged 2 commits intonumpy:maintenance/1.21.xfrom
charris merged 2 commits intonumpy:maintenance/1.21.xfrom
Conversation
This ensures that `help(np.dtype)` produces a result. I am not exactly sure why it picks up `__doc__` from the dict instead of `tp_doc` right now. It probably is due to the combination of inheritance and the fact that the dict always includes `None` and gets preference during inheritance. (That probably makes a lot of sense to not inherit the `type` docstring by default.) Modifying the dictionary directly is not really good style, either, but hopefully works. Closes numpygh-18740
Co-authored-by: Warren Weckesser <warren.weckesser@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #19775.
This ensures that
help(np.dtype)produces a result. I am notexactly sure why it picks up
__doc__from the dict instead oftp_doc right now. It probably is due to the combination of
inheritance and the fact that the dict always includes
Noneand gets preference during inheritance.
(That probably makes a lot of sense to not inherit the
typedocstring by default.)
Modifying the dictionary directly is not really good style, either,
but hopefully works.
Closes gh-18740