BUG: Remove logical object ufuncs with bool output #19640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While this makes sense, the implementation here does not actually work. It is very difficult to actually reach it, but if reached it just crashes the process, so remove it. (I am not actually sure why the input needs to be object already here, that seems to be an issue with the current dispatcher/promotion special casing object a bit oddly.)
Member
Author
|
Marking as backport candidate, since I think it should be OK to backport. |
Member
|
So this should not have been added in #14800 ? |
Member
Author
|
Yeah, should have been wrong from the start, we just misjudged the |
Member
|
Thanks @seberg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While this makes sense, the implementation here does not actually
work. It is very difficult to actually reach it, but if reached
it just crashes the process, so remove it.
(I am not actually sure why the input needs to be object already
here, that seems to be an issue with the current dispatcher/promotion
special casing object a bit oddly.)
Stumbled/struggled with it for the ufunc reductions refactor, so splitting it out, since it is a bit strange inside that PR.
EDIT: The tests are a bit obscure, so here is a simpler repro: