MAINT: Refactor and simplify the main ufunc iterator loop code#19258
Merged
seberg merged 1 commit intonumpy:mainfrom Jun 17, 2021
Merged
MAINT: Refactor and simplify the main ufunc iterator loop code#19258seberg merged 1 commit intonumpy:mainfrom
seberg merged 1 commit intonumpy:mainfrom
Conversation
Member
Author
|
This changes the debug prints a bit, that is because it starts a merger of the "fancy" (masked) and non-fancy loops, and they differ a bit in what they print. |
5da9e86 to
6e144f0
Compare
mhvk
reviewed
Jun 16, 2021
Contributor
mhvk
left a comment
There was a problem hiding this comment.
Agreed this is better, especially not having the whole loop inside an if clause. And good to avoid a large diff for no functional change in the big PR!
Only one comment about a comment...
59b7b64 to
ae6b18a
Compare
mattip
reviewed
Jun 17, 2021
Simple cleanups to the main ufunc loop code in preparation of larger ones.
ae6b18a to
23600c6
Compare
mattip
reviewed
Jun 17, 2021
| NPY_END_THREADS; | ||
| if (!needs_api) { | ||
| NPY_BEGIN_THREADS_THRESHOLDED(full_size); | ||
| } |
Member
There was a problem hiding this comment.
wow, the original NPY_BEGIN_THREADS_NDITER is a very convoluted macro. Glad to see it gone here.
mattip
approved these changes
Jun 17, 2021
Member
mattip
left a comment
There was a problem hiding this comment.
Nice cleanup. Once CI passes I think this can be merged.
Member
Author
|
Thanks Marten and Matti, will put it in to rebase the other one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple cleanups to the main ufunc loop code in preparation of
larger ones.
Independent change, in preparation for the large NEP 43 refactor (although it makes sense on its own). Mainly to reduce the diff-size.