MAINT: Refactor output ufunc wrapping logic#19254
Merged
charris merged 1 commit intonumpy:mainfrom Jun 17, 2021
Merged
Conversation
This replaces the output wrapping logic to work towards (and simplify) the big ufunc refactor for NEP 43.
bc55fb7 to
ce6afb6
Compare
mhvk
approved these changes
Jun 16, 2021
Contributor
mhvk
left a comment
There was a problem hiding this comment.
Yes, this helps clarify the code. And helpful to reduce clutter in the big PR.
Member
|
Thanks Sebastian. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the output wrapping logic to work towards
(and simplify) the big ufunc refactor for NEP 43.
EDIT: In case you are wondering, the main point here is simplifying the error handling and reference counting. It gets confusing otherwise...