MAINT: Improve the placeholder annotations for the main numpy namespace (part 3)#18799
Merged
charris merged 5 commits intonumpy:mainfrom Apr 19, 2021
Merged
MAINT: Improve the placeholder annotations for the main numpy namespace (part 3)#18799charris merged 5 commits intonumpy:mainfrom
charris merged 5 commits intonumpy:mainfrom
Conversation
added 4 commits
April 17, 2021 18:08
The default `__new__` is inherited from `object`, which takes no arguments and is therefore too restrictive
`cast` and `nbytes` are in fact instances of a `dict` subclass that converts passed `DTypeLike` objects into the actual keys (`np.generic`)
…ly1d` While the presence of `__getattr__` should be enough to consider an object callable, this is apparently not the case.
Member
Author
|
Any idea what could be going on with the travis failure? (https://travis-ci.com/github/numpy/numpy/jobs/499260617) |
Member
Don't worry about it, ppc64le wanders in and out of availability. |
Member
|
Thanks Bas. |
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on #18780:
This PR introduces a number of fixes related to aforementioned PR:
object-inherited) class constructor takes no arguments.castandnbyteswill automatically convertDTypeLikekeys into agenericsubclass.stepdefault value was missing fromnp.arange__getattr__method, an object is (unjustly) notconsidered a callable without an explicit
__call__method.