BUG: Regression #18075 | Fixing Ufunc TD generation order#18751
Merged
charris merged 2 commits intonumpy:mainfrom Apr 12, 2021
Merged
BUG: Regression #18075 | Fixing Ufunc TD generation order#18751charris merged 2 commits intonumpy:mainfrom
charris merged 2 commits intonumpy:mainfrom
Conversation
Member
Author
|
Ok so a couple of doubts :) :
|
Member
|
NumPy picks the first loop that "works" right now (that is defined by "safe casting", although I don't like that way of thinking about it much). So bool can cast to anything, so that means the first loop is taken. But (especially for scalars!) the correct order is important. (I am myself now a bit confused why 0-D arrays seem cased ;), but lets not worry about it) |
Member
|
Thanks @ganesh-k13 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RCA:
Reason: TD order of floor divide ufunc got changed. Expected signed before unsigned.
Escape Reason: Testplan gap, Execution gap
Found By:
pandas-dev/pandas#40874
UT Added: Yes
Note: Please let me know if we need to move it somewhere else
cc: @seberg