MAINT: Allow more recursion depth for scalar tests. #18750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test_operator_object_left and test_operator_object_right tests in test_scalarmath.py set a maximum recursion depth of 100 that caused an error in gitpod because it was too close to the starting depth of 75. The fix here is to raise the maximum depth to 200. Closes numpy#18749
Member
Author
|
This change seems to work on gitpod. Not sure when this will show up when starting gitpod, it seems to run a bit behind the latest updates to master. EDIT: My mistake, gitpod does seem to keep current. |
Member
|
Thanks Chuck! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test_operator_object_left and test_operator_object_right tests in
test_scalarmath.py set a maximum recursion depth of 100 that caused an
error in gitpod because it was too close to the starting depth of 75.
The fix here is to raise the maximum depth to 200.
Closes #18749