BUG: Fix ma coercion list-of-ma-arrays if they do not cast to bool#18605
Merged
charris merged 3 commits intonumpy:mainfrom Mar 16, 2021
Merged
BUG: Fix ma coercion list-of-ma-arrays if they do not cast to bool#18605charris merged 3 commits intonumpy:mainfrom
charris merged 3 commits intonumpy:mainfrom
Conversation
There was a regression here due to force casting to bool, but if that happens to fail (it does, but should not for strings). The mask would just be dropped. Of course masked arrays are held together by faith here, but its a regression. Closes numpygh-18551
seberg
commented
Mar 12, 2021
seberg
commented
Mar 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a regression here due to force casting to bool, but if that
happens to fail (it does, but should not for strings). The mask
would just be dropped.
Of course masked arrays are held together by faith here, but its
a regression.
Closes gh-18551
This is a small regression introduced when the ragged warning was added. Apparently, this code runs into it (but I assume should not). So the dtype has to be passed to avoid a warning.
I tried to remove the inner asarray call, but it runs into the warnings. Replacing the
dtypewith the original (which is arguably right, since the result is definitely not masked) works. If that is too shady for a backport and we want one, I can try to look further.