BUG: Fix tiny memory leaks when like= overrides are used
#18420
Merged
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I thought I had fixed these leaks, but it appears I missed some. We probably should backport this to 1.20.x (its simple), but the leaks are also pretty harmless unless someone uses `like=` hundrets of thousands of times in a running program (and its a new fetaure).
Member
|
Thanks @seberg |
like= overrides are usedlike= overrides are used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought I had fixed these leaks, but it appears I missed some.
We probably should backport this to 1.20.x (its simple), but the leaks
are also pretty harmless unless someone uses
like=hundrets ofthousands of times in a running program (and its a new fetaure).
I was running valgrind checks again on master and noticed this, I think last time around I found these same leaks, but apparently did not fix them everywhere and then did not rerun the full test suit (It runs more than a day the way I run it).