Conversation
Addresses gh-18321. Also fixes a typo where `font-style` instead of `font-family` was used. Since the font boldness and letter-spacing choices were built on top of this mistake, they were removed too. If someone feels the pydata-sphinx-theme would look nicer with some layout tweaks, I would strongly encourage them to adjust the theme itself upstream.
|
I don't think you should undo the font-weight, I think it is identical to the |
|
I can't find a matching font-weight in numpy.org/css/styles.css, but if we pick a matching one that feels very sensible. Regarding letter spacing, I removed that because the choice varies dramatically with the font, and the old choice was accidentally made with the wrong font. |
|
EDIT: This is it probably?: |
|
Yeah, that looks like it - but it was 700 not 900 before anyway! |
|
Merging. We can always tweak more if needed, but I think the idea of sticking to defaults is good. |
|
Thanks @eric-wieser |
|
@bjnath, feel free to create a PR restoring some overrides, especially if they make things consistent with numpy.org |
Addresses gh-18321.
Also fixes a typo where
font-styleinstead offont-familywas used. Since the font boldness and letter-spacing choices were built on top of this mistake, they were removed too.If someone feels the pydata-sphinx-theme would look nicer with some layout tweaks, I would strongly encourage them to adjust the theme itself upstream.
Before:
After: