Skip to content

ENH: Add dtype-support to the ufunc-based ndarray magic methods 4/4#18417

Merged
rgommers merged 6 commits intonumpy:mainfrom
BvB93:comparison5
Mar 6, 2021
Merged

ENH: Add dtype-support to the ufunc-based ndarray magic methods 4/4#18417
rgommers merged 6 commits intonumpy:mainfrom
BvB93:comparison5

Conversation

@BvB93
Copy link
Member

@BvB93 BvB93 commented Feb 15, 2021

Followup on #18323.

The last part in a series of PRs to add dtype-support to the (ufunc-based) ndarray magic methods.

The methods updated herein are, specifically, the inplace magic methods (plus some minor improvements to various mypy-based test messages).

Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BvB93. This LGTM, just one question.

Base automatically changed from master to main March 4, 2021 02:05
@rgommers rgommers merged commit eff28c4 into numpy:main Mar 6, 2021
@rgommers
Copy link
Member

rgommers commented Mar 6, 2021

Merged, thanks @BvB93.

@BvB93 BvB93 deleted the comparison5 branch April 20, 2021 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants