BUG: Fix iterator shape in advanced index assignment broadcast error#18404
Merged
mattip merged 1 commit intonumpy:masterfrom Feb 22, 2021
Merged
BUG: Fix iterator shape in advanced index assignment broadcast error#18404mattip merged 1 commit intonumpy:masterfrom
mattip merged 1 commit intonumpy:masterfrom
Conversation
The reported shape always missed the transpose operation, this refactors the transpose getting out and applies it in the error path. Closes numpygh-18401, numpygh-5710
mattip
approved these changes
Feb 14, 2021
Member
mattip
left a comment
There was a problem hiding this comment.
LGTM, +/- bikeshedding the function name
Member
|
Thanks @seberg |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reported shape always missed the transpose operation, this refactors
the transpose getting out and applies it in the error path.
Closes gh-18401, gh-5710