ENH: Add a mypy plugin for exposing platform-specific extended-precision types#18322
Merged
charris merged 6 commits intonumpy:masterfrom Feb 8, 2021
Merged
ENH: Add a mypy plugin for exposing platform-specific extended-precision types#18322charris merged 6 commits intonumpy:masterfrom
charris merged 6 commits intonumpy:masterfrom
Conversation
BvB93
commented
Feb 4, 2021
numpy/__init__.pyi
Outdated
Member
Author
There was a problem hiding this comment.
Effectively the plugin removes all import statements that are invalid for the platform in question.
The full list of (potential) extended-precision types was taken from numpy/__init__.pxd.
Member
Author
|
Anyone knows what's going with the PyPy tests? |
Member
It uses a nightly build since there is not an official release for win64 yet. Let's see if this repeats. |
added 6 commits
February 5, 2021 17:55
String-encasing is redunant now that we can use `from __future__ import annotations`
01d5c89 to
53496cd
Compare
Member
|
Thanks Bas. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies numpy's mypy plugin such that it manages all platform-specific extended-precision types (e.g.
float128). More specifically, it removes all extended-precision types unavailable to the platform in question, rather than adding them.The advantage of their removal (rather than addition) is that aforementioned types will still be available for use even without enabling the plugin. On the flip side, this does mean that, without the plugin, every single extended-precision type is "available" on every single platform.
The plugin can be enabled via one's
mypy.inifile:Examples
With the plugin enabled.