DOC: Clarify the type alias deprecation message#18230
Merged
charris merged 5 commits intonumpy:masterfrom Jan 26, 2021
Merged
Conversation
Member
Author
|
I tried to give some more details about integers in the release notes, and mention the precision version |
Member
|
What was the reason to change the 1.20.0 release note? |
charris
reviewed
Jan 26, 2021
charris
reviewed
Jan 26, 2021
charris
reviewed
Jan 26, 2021
Member
Author
|
Thanks, have to try how to fix that reference. Will fix (maybe tomorrow morning). There was some discussion that this release note/deprecation is maybe a bit unclear. I hope this is a bit clearer (and "recipe style"), so the idea was to change it before the release. |
This tries to clarify the type alias deprecation message slightly to give more guidance on how to review the replacement (if desired).
eric-wieser
reviewed
Jan 26, 2021
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
eric-wieser
reviewed
Jan 26, 2021
eric-wieser
reviewed
Jan 26, 2021
eric-wieser
reviewed
Jan 26, 2021
Member
|
This looks great, thanks @seberg! |
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
seberg
commented
Jan 26, 2021
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Member
Author
|
Thanks Eric and Ross for figuring out how to correctly link the user guide... applied the changes, so should be good to go (assuming CI passes now). |
Member
|
Thanks sebastian. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tries to clarify the type alias deprecation message slightly
to give more guidance on how to review the replacement (if desired).
The new messages are as follows: