BUG: Fix f2py bugs when wrapping F90 subroutines.#18184
Merged
charris merged 8 commits intonumpy:masterfrom Jan 19, 2021
Merged
BUG: Fix f2py bugs when wrapping F90 subroutines.#18184charris merged 8 commits intonumpy:masterfrom
charris merged 8 commits intonumpy:masterfrom
Conversation
…des. Don't split inline comments.
…rces to be compiled. Closes numpy#17797.
charris
reviewed
Jan 18, 2021
charris
reviewed
Jan 19, 2021
Member
|
LGTM, just a couple of style suggestions. |
eric-wieser
reviewed
Jan 19, 2021
eric-wieser
reviewed
Jan 19, 2021
eric-wieser
reviewed
Jan 19, 2021
charris
reviewed
Jan 19, 2021
Member
|
Thanks Pearu. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the following bugs:
__user__) must not be used in Fortran sources to be compiledThe PR supersedes #17800