BUG: Fix incorrectly passed size in masked processing#17828
BUG: Fix incorrectly passed size in masked processing#17828charris merged 1 commit intonumpy:masterfrom
Conversation
As noted in numpygh-17198 this was introduced when adding the error return due to a bad copy or similar. Bad commit is 37dc69c Closes numpygh-17198
|
I'm curious why only some of the returns from |
|
There are a few masked ones that I missed, I was going to make a PR tomorrow for them. Almost all should be checked, there may be some that just can never error, but those should be pretty deep, e.g. in |
|
@charris to be clear, the The function here actually is supposed to return the number of processed elements (as per documentation), but... That fact is not even used (I presume it was used in some initial version, or just done with potential improvement in mind). There is some reason for doing that, but it is one of those things that is reaching my limit of playing it out without having a clear, simple, use. |
Probably copied from similar C library functions (read/write). |
|
Thanks Sebastian. |
As noted in gh-17198 this was introduced when adding the error
return due to a bad copy or similar. Bad commit is
37dc69c
Closes gh-17198