MAINT: Move the fromnumeric annotations to their own stub file#17309
Merged
charris merged 1 commit intonumpy:masterfrom Sep 16, 2020
Merged
MAINT: Move the fromnumeric annotations to their own stub file#17309charris merged 1 commit intonumpy:masterfrom
fromnumeric annotations to their own stub file#17309charris merged 1 commit intonumpy:masterfrom
Conversation
Member
Author
|
CircleCI is failing but this is a known issue (#17301). |
Member
|
NumPy redefines the module that functions are reported to come from; does this cause any inconsistencies with that? |
Member
Author
For classes this would indeed be a bit of an issue, as it the likes of mypy use the classes' module for defining its name. import numpy as np
array: np.ndarray
reveal_type(array) # Revealed type is 'numpy.ndarray'
reveal_type(np.reshape) # Revealed type is 'def (...)' |
Member
|
Thanks @BvB93 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request moves the
fromnumericannotations to their own dedicated stub file.This should clean up the main
__init__.pyifile a bit.