BUG, DOC: comment out metadata added via javascript#17220
Merged
mattip merged 1 commit intonumpy:masterfrom Sep 4, 2020
Merged
BUG, DOC: comment out metadata added via javascript#17220mattip merged 1 commit intonumpy:masterfrom
mattip merged 1 commit intonumpy:masterfrom
Conversation
Member
Author
|
Segfault in PyPy-linux is unrelated. |
Member
Author
|
Merging this one line change, I checked that the output HTML has the commented out code. If someone wants to suggest a different solution, please open a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts gh-17210, closes gh-17069
Rather than remove the uneeded line, I commented it out. Perhaps next time this come up it will remind us how this is done. Note for future self:
versionwarning.jsis added viaupdate.py, which is run as part of the deployment on the numpy/doc repo, as documented in the README there.