ENH: Added missing methods to np.flatiter#17180
Merged
mattip merged 7 commits intonumpy:masterfrom Sep 2, 2020
Merged
Conversation
added 5 commits
August 28, 2020 15:51
Added `__len__`, `__getitem__` and `__array__`
Member
Author
|
Pinging @bashtage. |
eric-wieser
reviewed
Aug 28, 2020
| a.index = Any # E: Property "index" defined in "flatiter" is read-only | ||
| a.copy(order='C') # E: Unexpected keyword argument | ||
| a[np.bool_()] # E: No overload variant of "__getitem__" | ||
| a[Index()] # E: No overload variant of "__getitem__" |
Member
There was a problem hiding this comment.
Shouldn't this be legal? Might be worth referencing an issue if its not.
Member
Author
Contrary to `ndarray.__getitem__` its counterpart in `flatiter` does not accept objects with the `__array__` or `__index__` protocols; boolean indexing is just plain broken (numpygh-17175)
bashtage
reviewed
Aug 28, 2020
| def __setitem__(self, key: str, value: bool) -> None: ... | ||
|
|
||
| _ArrayLikeInt = Union[ | ||
| int, |
Contributor
There was a problem hiding this comment.
Does [int, integer] include bool?
Member
Author
There was a problem hiding this comment.
It does as bool is a subclass of int.
There is, as far as I'm aware, no convenient way of annotating a function which accepts integers but rejects booleans.
Member
|
Thanks @BvB93 |
20 tasks
This was referenced Jan 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17114 and #17113.
This pull requests adds annotations to the following three
np.flatitermethods:__getitem__()__len__()__array__()