ENH: Call str on the third argument of assert_equal()#17011
Closed
asmeurer wants to merge 3 commits intonumpy:mainfrom
Closed
ENH: Call str on the third argument of assert_equal()#17011asmeurer wants to merge 3 commits intonumpy:mainfrom
asmeurer wants to merge 3 commits intonumpy:mainfrom
Conversation
This lets you pass any object, similar to how you would do for a native Python assert a == b, msg
Member
|
Should add a release note for this, probably under |
BvB93
reviewed
Aug 7, 2020
Member
|
@asmeurer Ping |
Member
|
Needs rebase to fix the CircleCI failure. |
cc27295 to
06670b5
Compare
Member
|
@asmeurer ping. Do you wish to pursue this? |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lets you pass any object, similar to how you would do for a native Python