MAINT: Implemented two dtype-related TODO's #16622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
reviewed
Jun 17, 2020
eric-wieser
reviewed
Jun 17, 2020
Member
Author
|
During the latest rebase two issues were introduced by accident. |
anirudh2290
approved these changes
Jul 16, 2020
Member
anirudh2290
left a comment
There was a problem hiding this comment.
Changes specific to this PR LGTM !
This was referenced Jul 17, 2020
person142
reviewed
Jul 30, 2020
added 14 commits
July 30, 2020 15:04
The `"titles"` key in `_DtypeDict' can take a sequence of any hashable object as argument.
* The `Protocol` baseclass of `_SupportsDtype` disappeared. * Ensure that `typing_extensions` is not imported during runtime, as it's not a hard NumPy dependency.
…., ...})` syntax Removed per the discussion in numpy#16891
Member
Author
|
Rebased to get rid of the circleci failure. |
Addresses numpy#16622 (comment) Co-Authored-By: Eric Wieser <eric-wieser@users.noreply.github.com>
Member
Author
|
If there are no more comments, remarks, etc. then let's get this merged soon, as #16917 is also waiting on this pull request. |
Member
|
I’ll take another look tonight. |
Member
|
Looks good to me, and test failure is unrelated so merging. Thanks @BvB93. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests addresses and implement two previous TODO's in
np.typing._DTypeLike:_SupportsDtype, for objects with thedtypeattribute.TypedDict.