Seems reasonable. If we want to put this in, it has to be in the next few days, since it is only useful for 1.19, after that 3.5 will be dropped and there is no further 1.18 release planned right now.

Python 3.5 is already dropped in 1.19, we couldn't support f-strings otherwise :) It is too bad that the 3.5 backport wasn't available earlier. If you really, really need it for 3.5 you might try patching a 1.18 source release and compiling yourself.

If you want to make this PR against the 1.18 branch I'll put it in just so it is there, but I don't expect to make another release of that branch. Could maybe make a source release if that would be helpful.

Oops, I did't know numpy 1.19 has dropped Python3.5 support. It is totally ok for me to put it in the 1.18 branch (even without another release).

@charris right. I think the release notes may need to be clarified a bit. It says of Python versions <3.5

I think the release notes may need to be clarified a bit.

Got it, thanks.

@suquark happy to put this in, there is one test related to importerror when using protocol 5 but its not available. Could you modify that as well just to be sure?

@charris right. I think the release notes may need to be clarified a bit. It says of Python versions <3.5

Came to do the same thing as @suquark and also was confused by this release note. Was going to submit a fix, but am now a bit perplexed by how release notes work. Where should we fix this?

@jakirkham The PR should be against maintenance/1.18.x, which is the last branch to support 3.5. If there is enough interest I could make another release of that branch. The easiest thing to do might be to close this PR, rebase on maintenance/1.18.x and resubmit.

@suquark You shouldn't be working in the master branch anyway. For two commits I'd do something like this:

$ git checkout -b <new branch>
$ git rebase HEAD~2 --onto maintenance/1.18.x
$ git checkout master
$ git reset --hard HEAD~2
$ git push -f origin HEAD

Which will clean up your master branch. Then push your new branch and open a PR.

Sorry Charles was meaning how to fix the release notes.

It seems Siyuan already has this fix in hand.

was meaning how to fix the release notes.

NumPy 1.19.0 is still in the rc stage, so the release notes aren't finalized yet. I'll take care of it in the rc2.