MAINT: cleanups to quantile#16274
Merged
eric-wieser merged 2 commits intonumpy:masterfrom May 17, 2020
Merged
Conversation
The `add` ufunc is happy to handle `out=None` by itself
It's easier to move the relevant axis to position 0 in `ap` first than it is to move it for every relevant object simultaneously.
seberg
approved these changes
May 17, 2020
Member
seberg
left a comment
There was a problem hiding this comment.
LGTM, feel free to merge. The np.add() out kwarg will cause a slight slowdown for small arrays, but I think we should probably not care.
I guess the moveaxis call could really be moved all the way up to after the ap definition, so that the whole function basically works on axis=0...
Member
Author
I have some more local changes to do just that :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a log of noisy reshaping going on here that just gets in the way of seeing the algorithm.
Inspired by #15098 and #16273