ENH: backport scipy changes to openblas download script#16213
ENH: backport scipy changes to openblas download script#16213charris merged 2 commits intonumpy:masterfrom
Conversation
|
How does the User-Agent work? I'm a bit concerned of the maintenance requirements here. Does the affect the wheel builds? |
|
I agree, this add a burden we did not have previously
I copied the code from scipy. Anaconda.org tries to minimally prevent mass scraping of its site by robots. The older urllib library downloads the artifact and identifies as one of the blocked "robots". Adding a User-Agent means urllib pretends to be a web browser instead. This behaviour is built into urllib3 and wget.
No, the wheel builds use this file to download openblas. The cost will come when we update openblas: we will have to regenerate the hashes. Ideally we would output the hashes as part of the |
|
Thanks Matti. I confess that I didn't see a problem with urllib3, it seems widely used. |
xref scipy/scipy#12094
python3 tools/openblas_support.py --testto print out the current hases)urllib3