REV: Reverts side-effect changes to casting#16109
Merged
charris merged 1 commit intonumpy:maintenance/1.18.xfrom Apr 30, 2020
Merged
REV: Reverts side-effect changes to casting#16109charris merged 1 commit intonumpy:maintenance/1.18.xfrom
charris merged 1 commit intonumpy:maintenance/1.18.xfrom
Conversation
This mostly reverts commit 6b954aa to ensure only the longdouble floating point numbers are changed, for which this was a bugfix was relevant. All other numbers should be unchanged (and were faster with the change), but revert since this is a bugfix release. Mainly the string->boolean conversions where accidentally changed to arguably more correct behaviour. But this should not have happend accidentally, especially in a bug-fix branch. Another corner case change is that string->datetime casts within hypothetical C-extensions doing manual C-level casting was fixed to be in line with normal string -> datetime casts (the cast was inconsistently defined). This revert is only applied as a backport. The second change will remain included in the next non-bugfix release while the first is fixed in a more specific in cleaner manner.
0b13628 to
f6cdbfa
Compare
seberg
commented
Apr 29, 2020
Comment on lines
+1530
to
+1531
| * #convert = 1*14, 0, 1*3, 0*3, 1*2, | ||
| * 1*14, 0, 1*3, 0*3, 1*2, |
Member
Author
There was a problem hiding this comment.
@charris, this reverts the commit (except the tests). With this only longdouble is affected by the fixup, for which it fixes a bug, and is not just a bit of a jumping through hoops.
The two lines above should be the only change remaining from the original backport., i.e. the original fix effectively set convert = 0 for all types. This one only does it for longdouble.
Member
|
Close/reopen |
Member
|
Thanks Sebastian. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This mostly reverts commit 6b954aa
to ensure only the longdouble floating point numbers are changed, for
which this was a bugfix was relevant.
All other numbers should be unchanged (and were faster with the change),
but revert since this is a bugfix release.
Mainly the string->boolean conversions where accidentally changed to
arguably more correct behaviour. But this should not have happend
accidentally, especially in a bug-fix branch.
Another corner case change is that string->datetime casts within
hypothetical C-extensions doing manual C-level casting was fixed to be in
line with normal string -> datetime casts (the cast was inconsistently
defined).
This revert is only applied as a backport. The second change will remain
included in the next non-bugfix release while the first is fixed in
a more specific in cleaner manner.