ENH: correct identity for logaddexp2 ufunc: -inf#16102
Conversation
The lack of identity for `logaddexp2` was first identitifed in numpy#4599. The implementation in numpy#8955 added -inf as identity for `logaddexp`, but missed adding it for `logaddexp2`.
|
Error looks unrelated. I believe @mattip is working on a fix. |
Co-Authored-By: Eric Wieser <wieser.eric@gmail.com>
|
CI failure is bizarre: Looks like a real bug in numpy (not being installable across drive boundaries), but clearly not the fault of this PR. |
|
Azure changed something. PR gh-16101 is waiting for review |
|
Note this is pretty critical since the macos documentation checks are all run only if a preliminary windows run succeeds, so nep and doc PRs should not be merged till this is fixed |
|
One slight curiosity is that |
|
Thanks for a nice first PR, looking forward to more! (Just waiting for the test to finish before merging). |
|
Oh, I forgot about the potential inclusion in the release notes. @eriknw can you add a very short release note statement, as detailed in https://github.com/numpy/numpy/blob/master/doc/release/upcoming_changes/README.rst |
|
Release note added. Sorry for the delay. |
ENH: use valid link in update note Co-authored-by: Sebastian Berg <sebastian@sipsolutions.net>
|
Thanks for the followup! |
|
My pleasure, and thanks for being very welcoming, prompt, and helpful! |
The lack of identity for
logaddexp2was first identified in #4599. The implementation in #8955 added-infas identity forlogaddexp, but missed adding it forlogaddexp2.(This is my first PR to numpy!)