MAINT: Replace npyiter_order_converter with PyArray_OrderConverter#16009
MAINT: Replace npyiter_order_converter with PyArray_OrderConverter#16009seberg merged 1 commit intonumpy:masterfrom
Conversation
The TODO precondition now holds, so we no longer need this function.function_base.py A consequence of this change is that: * `None` is now accepted as an alias for `'K'` * Lowercase letters are now accepted as a replacement for the corresponding uppercase letter Neither of these are particularly desirable, but we could always deprecate them in PyArray_OrderConverter at a later date.
5117119 to
6186544
Compare
|
Are we ok with this relaxing the argument specification, or should I add a new |
|
Yeah, its nonsense to do it differently for one function, we could generally deprecate the lower case if we like instead (not sure its worth the noise)... |
|
The todo appears to have come from fe791db |
|
Nvm, was just surprised for a bit before deciding that it doesn't really matter and clarifying that the other PR did not change behaviour/was not an actual prerequisite. Looks all fine to me, just waiting for tests. Thanks. |
|
Hmm. I think the other PR almost was a prequisite, but 10 days is too long for me to remember why. |
|
I suppose there may be some corner cases... with the error type or so. |
|
That's probably what it was. |
Builds upon #16008, marking as draft until that is mergedThe TODO precondition now holds, so we no longer need this function.function_base.py
A consequence of this change is that:
Noneis now accepted as an alias for'K'Neither of these are particularly desirable, but we could always deprecate them in
PyArray_OrderConverterat a later date.