TST: Add tests for the conversion utilities#16007
Merged
mattip merged 1 commit intonumpy:masterfrom Apr 22, 2020
Merged
Conversation
329b172 to
5094a46
Compare
This way we can test them without having to try and guess their behavior from the functions that use them. This also makes a bit more apparently the inconsistencies between them.
5094a46 to
9dac4d5
Compare
anirudh2290
approved these changes
Apr 17, 2020
anirudh2290
reviewed
Apr 17, 2020
| class StringConverterTestCase: | ||
| allow_bytes = True | ||
| case_insensitive = True | ||
| exact_match = False |
Member
There was a problem hiding this comment.
this is a bit weird, why do we support partial matches, seems like it can cause confusion with user code when C can be used for order as well as mode.
Member
Author
There was a problem hiding this comment.
I agree it's weird, but my goal of this PR was to test the behavior that's already present. I wouldnt be opposed to someone else championing for deprecations once this is in.
Member
There was a problem hiding this comment.
Indeed, Every time I saw it, I thought it should be deprecated, but it also never felt super pressing. Which doesn't mean it shouldn't be done, just that I didn't particularly feel like actually doing it when stumbling over it :).
Member
|
Thanks @eric-wieser |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way we can test them without having to try and guess their behavior from the functions that use them.
This also makes a bit more apparently the inconsistencies between them.
Written because I found some bugs in the converters, and had nowhere good to put the tests.