DEP: Do not cast boolean indices to integers in np.delete#15815
Merged
WarrenWeckesser merged 3 commits intonumpy:masterfrom Mar 25, 2020
Merged
DEP: Do not cast boolean indices to integers in np.delete#15815WarrenWeckesser merged 3 commits intonumpy:masterfrom
WarrenWeckesser merged 3 commits intonumpy:masterfrom
Conversation
This expires a deprecation from 1.8. The corresponding deprecation in `np.insert` has less clear semantics, so has been left to a future patch.
dfe7817 to
d6ac58a
Compare
WarrenWeckesser
approved these changes
Mar 25, 2020
Member
WarrenWeckesser
left a comment
There was a problem hiding this comment.
I suggested one correction, otherwise looks good.
Member
|
Suggested fix was trivial, so just commited it and merged. Thanks @eric-wieser. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This expires a deprecation from 1.8.
The corresponding deprecation in
np.inserthas less clear semantics, so has been left to a future patch.