Skip to content

DEP: Forbid passing non-integral index arrays to insert and delete#15805

Merged
seberg merged 1 commit intonumpy:masterfrom
eric-wieser:expired-insert-delete-TypeError
Mar 23, 2020
Merged

DEP: Forbid passing non-integral index arrays to insert and delete#15805
seberg merged 1 commit intonumpy:masterfrom
eric-wieser:expired-insert-delete-TypeError

Conversation

@eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Mar 22, 2020

This expires a deprecation warning from back in 1.9.

See also gh-15802, gh-15804

This expires a deprecation warning from back in 1.9.
@eric-wieser eric-wieser force-pushed the expired-insert-delete-TypeError branch from 5eac19f to 849756f Compare March 22, 2020 20:30
@mattip
Copy link
Member

mattip commented Mar 23, 2020

LGTM. There are no test_deprecations tests to remove?

@eric-wieser
Copy link
Member Author

Seemingly not

@eric-wieser eric-wieser changed the title DEP: Forbid passing non-integral arrays to insert and delete DEP: Forbid passing non-integral index arrays to insert and delete Mar 23, 2020
@seberg
Copy link
Member

seberg commented Mar 23, 2020

This may very well be older than test deprecations :), I added that one some time after the integer deprecations IIRC. The main purpose at the time was that (deprecation)warning testing was getting almost impossible. Thanks Eric.

@seberg seberg merged commit 9ae4a0d into numpy:master Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants