DEP: Make issubdtype consistent for types and dtypes#15773
Merged
WarrenWeckesser merged 4 commits intonumpy:masterfrom Mar 22, 2020
Merged
DEP: Make issubdtype consistent for types and dtypes#15773WarrenWeckesser merged 4 commits intonumpy:masterfrom
WarrenWeckesser merged 4 commits intonumpy:masterfrom
Conversation
This finishes the deprecation started in numpygh-9505 removing behaviour that allowed strings/types representing specific dtypes to behave like their more generic supertypes (e.g. the python float would map to floating instead of float64 which it typically maps to).
440c236 to
0769f8c
Compare
Member
Author
|
Hmmm, made the commit DEP, but since it is a future warning, put the relase note into |
eric-wieser
reviewed
Mar 18, 2020
eric-wieser
approved these changes
Mar 18, 2020
Co-Authored-By: Eric Wieser <wieser.eric@gmail.com>
…py into issubdtype-finish-deprecation
Member
|
Thanks @seberg and @eric-wieser. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This finishes the deprecation started in gh-9505 removing
behaviour that allowed strings/types representing specific dtypes
to behave like their more generic supertypes (e.g. the python
float would map to floating instead of float64 which it typically
maps to).