BUG: lib: Handle axes with length 0 in np.unique.#15747
Conversation
numpy/lib/arraysetops.py
Outdated
There was a problem hiding this comment.
This if could probably do with a brief comment explaining why the special case is needed
There was a problem hiding this comment.
I pushed an update that added comments about this if statement. Copy-editing suggestions are welcome!
eric-wieser
left a comment
There was a problem hiding this comment.
This looks great, thanks for looking for a tidier solution
dd92665 to
530f1cf
Compare
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
@seberg @WarrenWeckesser There's the reason--these comment triggers are pretty handy. |
|
@chrispat Any ideas here? We haven't changed our YML file recently. |
|
@vtbassmatt have there been any updates in path filtering? |
|
@tylerjereddy, @chrispat: Looks like we're not the only ones: https://stackoverflow.com/questions/60677704/why-did-azure-pipelines-suddenly-stopped-appearing-in-pr-on-github-open-source |
|
Indeed, cross-linked SciPy PR above seems to fail at the moment too. |
|
We're having an incident at the moment. Engineering is engaged. |
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
@vtbassmatt is there a place we can monitor progress on the incident? |
…th 0 axis.
This code is from github user huonw, from this PR:
numpy#15565
Tweak a few lines so that arrays with an axis with length 0 don't break the np.unique code. Closes numpygh-15559.
428d10a to
3068943
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Thanks @WarrenWeckesser |
This PR is an alternative to gh-15565. It avoids the big block of special-case code in that PR.