DOC: Add release note about changed random variate stream from random.Generator.integers #14782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3982f31 to
4e345ad
Compare
Member
Author
|
@mattip or anyone else, does this look like the right way to document a change in the random variate stream in a new release? |
charris
reviewed
Oct 25, 2019
Member
There was a problem hiding this comment.
It would read better to put the last sentence first, something like.
There was a bug in `numpy.random.Generator.integers` that caused biased
sampling of 8 and 16 bit integer types. Fixing that bug has changed the output
stream from what is was in previous releases.
Member
Author
There was a problem hiding this comment.
@charris, yes, that sounds better. I pushed an update.
….Generator.integers
4e345ad to
7e5dc90
Compare
Member
|
LGTM, but I'll let someone more familiar with the new release note mechanism comment. |
charris
approved these changes
Oct 26, 2019
Member
|
Looks fine. You can see the result on the ci artifacts for the pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.