Skip to content

BLD: remove generated Cython files from sdist #14453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
charris merged 1 commit into from
Sep 8, 2019
+9 −3
Merged

BLD: remove generated Cython files from sdist #14453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions MANIFEST.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
# Avoid using MANIFEST.in for that.
#
include MANIFEST.in
include pyproject.toml
include pytest.ini
include *.txt
include README.md
Expand Down
6 changes: 5 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
[build-system]
# Minimum requirements for the build system to execute.
requires = ["setuptools", "wheel", "cython"] # PEP 508 specification
requires = [
"setuptools",
"wheel",
"Cython>=0.29.13", # Note: keep in sync with tools/cythonize.py
]


[tool.towncrier]
Expand Down
4 changes: 2 additions & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,8 +422,8 @@ def setup_package():
if run_build:
from numpy.distutils.core import setup
cwd = os.path.abspath(os.path.dirname(__file__))
if not os.path.exists(os.path.join(cwd, 'PKG-INFO')):
# Generate Cython sources, unless building from source release
if not 'sdist' in sys.argv:
# Generate Cython sources, unless we're generating an sdist
generate_cython()

metadata['configuration'] = configuration
Expand Down
1 change: 1 addition & 0 deletions tools/cythonize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ def process_pyx(fromfile, tofile):
# Cython 0.29.13 is required for Python 3.8 and there are
# other fixes in the 0.29 series that are needed even for earlier
# Python versions.
# Note: keep in sync with that in pyproject.toml
required_version = LooseVersion('0.29.13')

if LooseVersion(cython_version) < required_version:
Expand Down