EHN: Add support for vector atol and rtol in np.all_isclose and np…#14343
EHN: Add support for vector atol and rtol in np.all_isclose and np…#14343maxwell-aladago wants to merge 5 commits intonumpy:mainfrom
Conversation
|
Fixes #14320. |
|
Needs a release note. |
|
@charris, will this be ok for a release note? |
|
By the way, the component is |
|
@eric-wieser, @shoyer any more comments? |
|
close/reopen |
|
Is there a clear use case for this? I feel it is a bit too complicated to have non-scalar atol/rtol. |
|
If you disagree feel free to reopen. Please also describe the use case in the mailing list since this is an enhancement request. |
I've described a use case for this in this issue comment. Basically, if we want to ensure two vectors, but we want the absolute tolerances for some axes to be different from the absolute tolerances for other axes. |
|
Could you write to numpy-discussion proposing the enhancement? |
I've submitted a thread to the discussion. But it is not showing up yet. I'm quite new to this. Do I have to wait for the thread to be approved by moderators? |
|
Anyone want to finish this up? A new PR would also be fine. The docs are slightly off, there is no |
|
Closing, #24878 is a duplicate and was merged. Thanks @maxwell-aladago anyway. |
Fixes #14320.